Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to CLI ti set community bom if not running RHBQ #1279

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Sep 4, 2024

Summary

In tests with CLI we use apps, that have static sources. We need to be able to run it with both community and RHBQ builds.
Adding method, that will check if we're running with RHBQ and if not, set properties in app to use community BOM.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from michalvavrik September 4, 2024 14:31
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you

@michalvavrik michalvavrik merged commit 4f41e55 into quarkus-qe:main Sep 4, 2024
8 checks passed
@michalvavrik michalvavrik mentioned this pull request Sep 4, 2024
11 tasks
@mocenas mocenas deleted the add_cli_methods_to_framework branch September 5, 2024 06:27
@mocenas mocenas added the triage/backport-1.5? Quarkus 3.15 stream label Sep 17, 2024
@fedinskiy fedinskiy mentioned this pull request Oct 7, 2024
12 tasks
@fedinskiy fedinskiy removed the triage/backport-1.5? Quarkus 3.15 stream label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants