Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS registry and certificate reloading #1267

Merged

Conversation

michalvavrik
Copy link
Member

Summary

This is but a portion of required changes I have in progress. However I think reviews will be easier if we go in smaller chunks. This PR:

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/add-tls-registry-support branch 2 times, most recently from 949eb13 to 42d43ab Compare August 29, 2024 15:07
@michalvavrik michalvavrik requested a review from mjurc August 29, 2024 15:10
@michalvavrik michalvavrik force-pushed the feature/add-tls-registry-support branch from 42d43ab to e9d27bf Compare August 29, 2024 15:21
@mjurc mjurc added the triage/backport-1.5? Quarkus 3.15 stream label Aug 29, 2024
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice at cursory review. I can't see anything wrong, so LGTM!

@mjurc
Copy link
Member

mjurc commented Aug 29, 2024

Also added backport label, as we need this for 3.15 testing

@michalvavrik michalvavrik merged commit f6b0b86 into quarkus-qe:main Aug 29, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/add-tls-registry-support branch August 29, 2024 18:28
@michalvavrik michalvavrik mentioned this pull request Sep 3, 2024
11 tasks
@michalvavrik michalvavrik removed the triage/backport-1.5? Quarkus 3.15 stream label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants