Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.z] Build extensions profile in release workflow #1265

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

gtroitsk
Copy link
Member

Summary

Extensions profile was excluded from release workflow in backport PR. This Extensions metrics and tracing modules are still using in both 1.4.z and 1.3.z branches. Release is not updating artifact snapshot version for these modules, which causes build error, https://github.com/quarkus-qe/quarkus-test-framework/actions/runs/10564888607/job/29269815983?pr=1258

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk requested a review from mjurc August 28, 2024 13:47
@gtroitsk gtroitsk changed the title Build extensions profile in release workflow [1.4.z] Build extensions profile in release workflow Aug 28, 2024
@mjurc
Copy link
Member

mjurc commented Aug 28, 2024

I don't mind this but I am not sure how this got removed from all the release actions. This is not happening in main right now either. Do you remember?

@gtroitsk
Copy link
Member Author

I don't mind this but I am not sure how this got removed from all the release actions. This is not happening in main right now either. Do you remember?

Mentioned modules were removed from main, you can see PR. I don't know if we can remove them in this branch or not?

@mjurc
Copy link
Member

mjurc commented Aug 28, 2024

Thanks for explanation, I understand now. Thank you. LGTM.

@mjurc mjurc merged commit 7e9382c into quarkus-qe:1.4.z Aug 28, 2024
7 checks passed
@gtroitsk gtroitsk mentioned this pull request Sep 2, 2024
11 tasks
@gtroitsk gtroitsk deleted the fix-release-workflow branch September 2, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants