Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport quarkus CLI update support #1247

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Aug 14, 2024

Summary

Backport of changes for quarkus CLI update tests. From PRs:

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mocenas mocenas requested a review from michalvavrik August 14, 2024 12:24
@mocenas mocenas force-pushed the backport_changes branch 3 times, most recently from 89b71c2 to 8f4895f Compare August 14, 2024 13:14
@michalvavrik
Copy link
Member

CLI failures look related.

@mocenas
Copy link
Contributor Author

mocenas commented Aug 15, 2024

CLI failures look related.

I investigated that. In the end I've disabled the test and opened an upstream issue, as this really seems like an problem in quakrus CLI in version 3.8.*. quarkusio/quarkus#42567
If steps like this doesn't work (even with upstream versions) then there is something wrong:

quarkus create app app --stream=3.2
cd app
quarkus update --stream=3.8

@rsvoboda
Copy link
Member

Why one bulk commit and not picks of the original commits (using git cherry-pick -x __HASH__)?

btw, -x is important as you will have reference to the original commit and thus the PR for better context.

@michalvavrik
Copy link
Member

I investigated that. In the end I've disabled the test and opened an upstream issue, as this really seems like an problem in quakrus CLI in version 3.8.*. quarkusio/quarkus#42567
If steps like this doesn't work (even with upstream versions) then there is something wrong:

makes sense

@mocenas
Copy link
Contributor Author

mocenas commented Aug 15, 2024

Why one bulk commit and not picks of the original commits (using git cherry-pick -x __HASH__)?

btw, -x is important as you will have reference to the original commit and thus the PR for better context.

To be frank, I tried to do that way, but git cherry-pick was trolling me so hard, that I decided to go this way instead.

@mocenas
Copy link
Contributor Author

mocenas commented Aug 15, 2024

I've also disabled the shouldUpdateApplication test which is failing for same reason - quarkusio/quarkus#42567

@michalvavrik michalvavrik merged commit 29cc69e into quarkus-qe:1.4.z Aug 15, 2024
7 checks passed
@mocenas mocenas deleted the backport_changes branch August 15, 2024 10:39
@mocenas mocenas mentioned this pull request Aug 15, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants