-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport quarkus CLI update support #1247
Conversation
89b71c2
to
8f4895f
Compare
examples/quarkus-cli/src/test/resources/existingSourcesApp/pom.xml
Outdated
Show resolved
Hide resolved
CLI failures look related. |
8f4895f
to
ce99f99
Compare
I investigated that. In the end I've disabled the test and opened an upstream issue, as this really seems like an problem in quakrus CLI in version 3.8.*. quarkusio/quarkus#42567
|
Why one bulk commit and not picks of the original commits (using btw, |
makes sense |
To be frank, I tried to do that way, but git cherry-pick was trolling me so hard, that I decided to go this way instead. |
ce99f99
to
ef43a37
Compare
I've also disabled the shouldUpdateApplication test which is failing for same reason - quarkusio/quarkus#42567 |
Summary
Backport of changes for quarkus CLI update tests. From PRs:
Add extraArgs method to CLIAppManager #1241
Add checks into QuarkusCLIUtils #1239
Fix issues in QuarkusCLIUtils #1236
Add CLI testing utils #1235
Add method for creating CLI apps from existing sources #1233
Allow running CLI in dev mode, without overwriting quarkus version #1232
Add CLI feature to update quarkus app #1188
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Dependency update
Refactoring
Release (follows conventions described in the RELEASE.md)
Breaking change (fix or feature that would cause existing functionality to change)
This change requires a documentation update
This change requires execution against OCP (use
run tests
phrase in comment)Checklist: