Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snapshot in builds with snapshot CLI #1246

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Use snapshot in builds with snapshot CLI #1246

merged 1 commit into from
Aug 13, 2024

Conversation

mjurc
Copy link
Member

@mjurc mjurc commented Aug 13, 2024 •
edited
Loading

Summary

  • When snapshot version of Quarkus is used, the quarkus.version property should be set to Quarkus version set in the execution with build CLI command

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mjurc mjurc requested a review from michalvavrik August 13, 2024 14:45
@mjurc mjurc self-assigned this Aug 13, 2024
@mjurc
Use snapshot in builds with snapshot CLI
e478646 
* When snapshot version of Quarkus is used, the quarkus.version property
  should be set to Quarkus version set in the execution with build CLI command
@mjurc mjurc force-pushed the use-snapshot-in-cli-builds branch from 5f934cc to e478646 Compare August 13, 2024 15:16
@mjurc mjurc requested a review from michalvavrik August 13, 2024 15:45
michalvavrik
michalvavrik approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit dae8856 into quarkus-qe:main Aug 13, 2024
8 checks passed
@mjurc mjurc deleted the use-snapshot-in-cli-builds branch August 27, 2024 12:16
@michalvavrik michalvavrik mentioned this pull request Sep 11, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees

@mjurc mjurc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjurc @michalvavrik