Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QuarkusCliConfigEncryptIT for Windows OS #1238

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

jcarranzan
Copy link
Contributor

@jcarranzan jcarranzan commented Aug 6, 2024

Summary

Currently there are some failures in our win jobs related to QuarkusCliConfigEncryptIT because special characters Strings in QuarkusCliConfigEncryptIT class on Windows OS

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan force-pushed the escape-chars-on-Win branch 3 times, most recently from f5c2f04 to 1eac846 Compare August 6, 2024 09:41
Copy link

github-actions bot commented Aug 6, 2024

Following jobs contain at least one flaky test: 'Linux - JVM build - Latest Version'

@rsvoboda rsvoboda requested a review from michalvavrik August 6, 2024 11:13
@michalvavrik
Copy link
Member

rsvoboda requested a review from michalvavrik 7 minutes ago

this fix is needed, @jcarranzan is testing it ATM, there are other places that could be escaped as well

but it is not required to fix tests itself

@jcarranzan jcarranzan force-pushed the escape-chars-on-Win branch 2 times, most recently from 4b5ee3c to c448935 Compare August 8, 2024 12:47
@jcarranzan jcarranzan marked this pull request as ready for review August 8, 2024 14:35
@jcarranzan
Copy link
Contributor Author

I did a partial fix and additional improvements needs to be done to be working on Windows OS because still there are other issues:

[ERROR] Errors: 
[ERROR]   EncryptPropertyTest.encryptSecret_PlainKeyFormat_ExistingEncryptionKey:44->getSecret2:84 ? Runtime java.lang.IllegalArgumentException: Illegal bas
e64 character 5b
[ERROR]   EncryptPropertyTest.encryptedSecret_Base64SecretFormat_GeneratedEncryptionKey:39->getSecret1:80 ? Runtime java.lang.IllegalArgumentException: Ille
gal base64 character 5b
[ERROR]   EncryptPropertyTest.failToDecryptSecretInWrongFormat:60->getSecret3:88 ? Runtime java.lang.IllegalArgumentException: Illegal base64 character 5b  
[INFO]
[ERROR] Tests run: 6, Failures: 0, Errors: 3, Skipped: 1

@jcarranzan jcarranzan force-pushed the escape-chars-on-Win branch from 9344f40 to 2ab075a Compare August 21, 2024 09:03
@jcarranzan jcarranzan force-pushed the escape-chars-on-Win branch from 2ab075a to b39e0ac Compare August 21, 2024 09:03
@michalvavrik
Copy link
Member

Remaining failure for the set config test I cannot fix after spending days on that. I think when it's consequence of default encoding. We cannot expect that it will work without adjusting of the defaults on executors.

@michalvavrik michalvavrik merged commit 6bd4c13 into quarkus-qe:main Aug 25, 2024
8 checks passed
@michalvavrik michalvavrik deleted the escape-chars-on-Win branch August 25, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants