Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Groovy conflicts in Debug examples as daily build is failing #1196

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jul 9, 2024

Summary

Fixes 2 things that are causing daily build failing, both are related:

  • Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. Module [groovy-xml is loaded in version 4.0.22 and you are trying to load version 4.0.16

Every now and then we run into a situation when Groovy version is conflicting. It cannot be avoided when Quarkus QE Test Framework is build with a different version than used in tests. In past it happened as well and I simply disabled tests, but lately they were enabled here #1134 because the test worked. We are likely to run into this again so I suggest to avoid Groovy

  • [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:3.3.0:integration-test (default) on project examples-debug: Execution default of goal org.apache.maven.plugins:maven-failsafe-plugin:3.3.0:integration-test failed: A required class was missing while executing org.apache.maven.plugins:maven-failsafe-plugin:3.3.0:integration-test: org/apache/commons/io/FileUtils

No idea why it sometimes happen (happened to me thrice when I tried to fix the Groovy thingy), but it's easy to avoid by simply dropping Apache Utils from surefire debug provider

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested review from mjurc and gtroitsk and removed request for mjurc July 9, 2024 19:23
@michalvavrik
Copy link
Member Author

setting @gtroitsk as he was debugging this issue before me and he identified https://mvnrepository.com/artifact/io.rest-assured/rest-assured bump in Quarkus as cause of this. @mjurc can review if interested :-)

Copy link

github-actions bot commented Jul 9, 2024

Following jobs contain at least one flaky test: 'Windows - JVM build - Latest Version'

Copy link
Member

@gtroitsk gtroitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@michalvavrik michalvavrik merged commit eab3776 into quarkus-qe:main Jul 10, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/workaround-groovy-conflict branch July 10, 2024 09:10
@michalvavrik michalvavrik mentioned this pull request Jul 10, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants