Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Beta8 of the framework #1177

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

fedinskiy
Copy link
Contributor

Summary

The title says it all

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Release
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from michalvavrik June 26, 2024 09:55
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit 3e3c2c3 into quarkus-qe:main Jun 26, 2024
8 of 9 checks passed
@michalvavrik
Copy link
Member

@fedinskiy release flow is failing https://github.com/quarkus-qe/quarkus-test-framework/actions/runs/9681515160/job/26712468004 please have a look, I'm busy atm

@michalvavrik
Copy link
Member

looks like gpg_private_key is missing as we do use v6 of that GH action and I guess it has been updated in minor

@mjurc
Copy link
Member

mjurc commented Jun 26, 2024

Github actions can only see secrets from the trunk repository. Forks PRs don't have access to secrets.

The release PRs need to happen from this repository.

@michalvavrik
Copy link
Member

arg! thanks @mjurc I didn't check

@mjurc
Copy link
Member

mjurc commented Jun 26, 2024

np, it's easy to miss. Almost makes me think we should have a check for the origin too for when .github/project.yml is changed.

@michalvavrik
Copy link
Member

Almost makes me think we should have a check for the origin too for when .github/project.yml is changed.

+1

@mjurc
Copy link
Member

mjurc commented Jun 26, 2024

#1179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants