Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change resteasy to rest in some examples #1167

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Change resteasy to rest in some examples #1167

merged 2 commits into from
Jun 10, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jun 10, 2024

Summary

Updating PingPong and Consule example to use quarkus-rest.

Removing quarkus-resteasy from external aplication as it work without it.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented Jun 10, 2024

run tests

@jedla97 jedla97 requested a review from michalvavrik June 10, 2024 07:25
michalvavrik
michalvavrik reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change lgtm, I'm not sure about motivation to migrate endpoint return types to Uni so I suggest to mix it up

examples/consul/src/main/java/io/quarkus/qe/GreetingResource.java Outdated Show resolved Hide resolved
@jedla97 jedla97 force-pushed the change-resteasy-to-rest branch from 2083a6f to 18e3c30 Compare June 10, 2024 11:55
@jedla97
Copy link
Member Author

jedla97 commented Jun 10, 2024

run tests

@michalvavrik michalvavrik merged commit 5e7c2cf into quarkus-qe:main Jun 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedla97 @michalvavrik