Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to leverage Java 17 and avoid deprecated classes #1135

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented May 20, 2024

Summary

I checked every FW class to find something deprecated or only relevant for Quarkus 1.x versions and while doing it, did some small changes I would otherwise not do. This PR contains:

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/clean-up-17-refactoring branch from 21d2a06 to 654e878 Compare May 20, 2024 22:39
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik requested a review from jedla97 May 21, 2024 06:11
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring! These changes make sense to me. CI is passing so merging this.

@jedla97 jedla97 merged commit 95b2fdf into quarkus-qe:main May 21, 2024
10 checks passed
@michalvavrik michalvavrik deleted the feature/clean-up-17-refactoring branch May 21, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants