Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FIPS-compatible client certificate generation #1114

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Apr 30, 2024

Summary

We use client certificates in TS with insecure algorithms, I'd like to unify its generation and have web client configured with setup based on these generated certs.

You can see that this PR replaces insecure relaxed HTTPS communication with HTTPS communication that verifies host and validates server certificates on client side as well (unlike what Rest Assured did).

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from mjurc April 30, 2024 20:35
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/fips-client-certs branch 2 times, most recently from 7d99f56 to c24dfba Compare April 30, 2024 20:48
@michalvavrik
Copy link
Member Author

run tests

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incredibly useful and usable. LGTM.

Do we want this for 1.4 too?

@michalvavrik michalvavrik force-pushed the feature/fips-client-certs branch from c24dfba to fe3a22d Compare April 30, 2024 22:46
@michalvavrik
Copy link
Member Author

This looks incredibly useful and usable. LGTM.

Do we want this for 1.4 too?

Yes, and thank you. I've decided to add 2 features now:

  • ability to test client unknown to server
  • ability to test server unknown to client

The point is it is tested in TS Security/HTTPS module and I want to simplify it. It is very little change (2 flags), so I hope it's okay.

Hence changes. It's also the reason why I cancelled OCP CI (though this PR doesn't really change anything related to OCP, I just wanted to show it's fine).

@michalvavrik michalvavrik added the triage/backport-1.4? Quarkus 3.8 stream label Apr 30, 2024
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik merged commit 3b8f79c into quarkus-qe:main May 1, 2024
9 of 10 checks passed
@michalvavrik michalvavrik deleted the feature/fips-client-certs branch May 1, 2024 06:12
@michalvavrik michalvavrik removed the triage/backport-1.4? Quarkus 3.8 stream label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants