Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FIPS-compatible certificate generation #1097

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Apr 22, 2024

Summary

Quarkus QE Test Suite HTTP advanced module fails in FIPS-enabled environment as used certs are using unsupported algorithm. This PR unifies and fixes the way we generate these certs. The feature added here remains optional. Existing FW examples test DEV / Prod and also OCP secret mounting.

Please note this needs to be improved in near future to support other scenarios. I'm fixing one thing at the time.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/support-certs-generation-for-dev-and-quarkus-apps branch from 983ee11 to 449d93f Compare April 22, 2024 16:30
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/support-certs-generation-for-dev-and-quarkus-apps branch from 449d93f to c481447 Compare April 22, 2024 19:03
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/support-certs-generation-for-dev-and-quarkus-apps branch from c481447 to 4a319eb Compare April 22, 2024 22:01
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik marked this pull request as draft April 22, 2024 22:07
@michalvavrik michalvavrik force-pushed the feature/support-certs-generation-for-dev-and-quarkus-apps branch from 4a319eb to d9a5044 Compare April 22, 2024 22:26
@michalvavrik michalvavrik marked this pull request as ready for review April 22, 2024 22:26
@michalvavrik michalvavrik force-pushed the feature/support-certs-generation-for-dev-and-quarkus-apps branch from d9a5044 to b5d7a48 Compare April 22, 2024 23:07
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik requested a review from mjurc April 23, 2024 07:39
@michalvavrik michalvavrik force-pushed the feature/support-certs-generation-for-dev-and-quarkus-apps branch from b5d7a48 to c19f40e Compare April 23, 2024 08:21
@michalvavrik
Copy link
Member Author

run tests

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, this looks really helpful. Thanks a lot.

@mjurc mjurc merged commit c121f14 into quarkus-qe:main Apr 23, 2024
10 checks passed
@michalvavrik michalvavrik deleted the feature/support-certs-generation-for-dev-and-quarkus-apps branch April 23, 2024 12:05
@michalvavrik michalvavrik mentioned this pull request Apr 23, 2024
11 tasks
@michalvavrik michalvavrik added the triage/backport-1.4? Quarkus 3.8 stream label Apr 26, 2024
@michalvavrik michalvavrik removed the triage/backport-1.4? Quarkus 3.8 stream label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants