-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support FIPS-compatible certificate generation #1097
Merged
mjurc
merged 1 commit into
quarkus-qe:main
from
michalvavrik:feature/support-certs-generation-for-dev-and-quarkus-apps
Apr 23, 2024
Merged
Support FIPS-compatible certificate generation #1097
mjurc
merged 1 commit into
quarkus-qe:main
from
michalvavrik:feature/support-certs-generation-for-dev-and-quarkus-apps
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalvavrik
force-pushed
the
feature/support-certs-generation-for-dev-and-quarkus-apps
branch
from
April 22, 2024 16:30
983ee11
to
449d93f
Compare
run tests |
michalvavrik
force-pushed
the
feature/support-certs-generation-for-dev-and-quarkus-apps
branch
from
April 22, 2024 19:03
449d93f
to
c481447
Compare
run tests |
michalvavrik
force-pushed
the
feature/support-certs-generation-for-dev-and-quarkus-apps
branch
from
April 22, 2024 22:01
c481447
to
4a319eb
Compare
run tests |
michalvavrik
force-pushed
the
feature/support-certs-generation-for-dev-and-quarkus-apps
branch
from
April 22, 2024 22:26
4a319eb
to
d9a5044
Compare
michalvavrik
force-pushed
the
feature/support-certs-generation-for-dev-and-quarkus-apps
branch
from
April 22, 2024 23:07
d9a5044
to
b5d7a48
Compare
run tests |
michalvavrik
force-pushed
the
feature/support-certs-generation-for-dev-and-quarkus-apps
branch
from
April 23, 2024 08:21
b5d7a48
to
c19f40e
Compare
run tests |
mjurc
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man, this looks really helpful. Thanks a lot.
michalvavrik
deleted the
feature/support-certs-generation-for-dev-and-quarkus-apps
branch
April 23, 2024 12:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quarkus QE Test Suite HTTP advanced module fails in FIPS-enabled environment as used certs are using unsupported algorithm. This PR unifies and fixes the way we generate these certs. The feature added here remains optional. Existing FW examples test DEV / Prod and also OCP secret mounting.
Please note this needs to be improved in near future to support other scenarios. I'm fixing one thing at the time.
Please check the relevant options
run tests
phrase in comment)Checklist: