Fix runtime config properties recording in OpenShift #1094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes openshift-tf-jvm-nightly and openshift-tf-native-nightly. (full disclosure: I also mentioned they can be flaky due to network blips in at least one run of great many I executed, and there was many of blocking warnings, but I suppose that would be a separate issue if repeated)
OpenShiftExtensionIT and OpenShiftDockerBuildIT are failing with Quarkus 3.8.4 (but not 3.8.3) and 999-SNAPSHOT as runtime values recorder at build time are not kept any more quarkusio/quarkus#39604. In OpenShift, runtime system properties set to mvn when we do
.withProperty("quarkus.management.port", "9002")
are not propagated so we need to copy them always to application properties. This behavior is IMHO correct because the change in Quarkus solved leaking of sensitive information.Please check the relevant options
run tests
phrase in comment)Checklist: