Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kubernetes test scenario #1083

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Apr 7, 2024

Summary

Fix issue #433

Now services are exposed with NodePort instead of LoadBalancer
KubectlClient was updated to use the new functions from Fabric8 Kubernetes client, deprecated functions were removed.

Existing Kubernetes test coverage was run locally with connection to temporary Kubernetes cluster.

I add KubernetesPostgresqlIT to test containers creating for basic scenario.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

gtroitsk added 2 commits April 7, 2024 20:21
Expose services with NodePort instead of LoadBalancer
@gtroitsk
Copy link
Member Author

gtroitsk commented Apr 7, 2024

run kube tests

@gtroitsk gtroitsk requested a review from michalvavrik April 7, 2024 18:37
@gtroitsk
Copy link
Member Author

gtroitsk commented Apr 7, 2024

run kube tests

@michalvavrik
Copy link
Member

I don't really have comments as long as it works (CI is red), because the code looks ok on the first look. I'll re-check when the CI is green, but I don't expect issues.

Just one question - what will happen if I run K8 tests from 2 different PRs at one time? Is the host always specific to the ephemeral namespace?

@gtroitsk
Copy link
Member Author

run kube tests

@gtroitsk
Copy link
Member Author

I don't really have comments as long as it works (CI is red), because the code looks ok on the first look. I'll re-check when the CI is green, but I don't expect issues.

Just one question - what will happen if I run K8 tests from 2 different PRs at one time? Is the host always specific to the ephemeral namespace?

Host allows to use ephemeral namespace. I don't expect problems running k8s tests in multiple PRs at one time

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@michalvavrik michalvavrik merged commit 9ff1210 into quarkus-qe:main Apr 21, 2024
9 checks passed
@gtroitsk gtroitsk deleted the kubernetes-scenario branch April 21, 2024 12:10
@michalvavrik michalvavrik mentioned this pull request Apr 23, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants