Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set keystore file type as required due to upstream changes the type can't be inferred anymore #1060

Merged

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Mar 6, 2024

Summary

Sets keystore file type as tests are now failing. See quarkusio/quarkus#39106 and quarkusio/quarkus#39151 for explanation what changed and why it is okay.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk gtroitsk requested a review from michalvavrik March 6, 2024 09:27
@gtroitsk
Copy link
Member Author

gtroitsk commented Mar 6, 2024

run tests

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I knew about it but completely forgot to make action.

@gtroitsk
Copy link
Member Author

gtroitsk commented Mar 6, 2024

OC JVM failure is weird, it seems like network error with OpenStack instance

@gtroitsk
Copy link
Member Author

gtroitsk commented Mar 6, 2024

run tests

@gtroitsk
Copy link
Member Author

gtroitsk commented Mar 6, 2024

@michalvavrik There are 2 other failures, they goes from other modules and not related to this PR.

@michalvavrik michalvavrik merged commit 04f0854 into quarkus-qe:main Mar 6, 2024
8 of 10 checks passed
@gtroitsk gtroitsk deleted the set-keystore-type-explicitly branch March 7, 2024 07:58
@gtroitsk gtroitsk mentioned this pull request Mar 21, 2024
11 tasks
@michalvavrik
Copy link
Member

BTW I am adding backport as I either already changed these lines or will change this in PRs that needs to be backported to 1.4.z stream. so I want to avoid conflicts.

@michalvavrik michalvavrik added the triage/backport-1.4? Quarkus 3.8 stream label Apr 26, 2024
@mjurc mjurc removed the triage/backport-1.4? Quarkus 3.8 stream label Apr 29, 2024
@mjurc
Copy link
Member

mjurc commented Apr 29, 2024

Removing the backport label as this is already in 1.4 branch

@mjurc mjurc added the triage/backport-1.4? Quarkus 3.8 stream label Apr 29, 2024
@mjurc
Copy link
Member

mjurc commented Apr 29, 2024

And I am adding the backport label as it turns out that one of the 1.4.2.Beta8 tags actually held 1.4.3.Beta8 release of framework, and I based the 1.4.z branch on that wrongly...

@jedla97
Copy link
Member

jedla97 commented Jun 5, 2024

Removing backport label as this was part of #1105

@jedla97 jedla97 removed the triage/backport-1.4? Quarkus 3.8 stream label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants