-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set keystore file type as required due to upstream changes the type can't be inferred anymore #1060
Set keystore file type as required due to upstream changes the type can't be inferred anymore #1060
Conversation
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I knew about it but completely forgot to make action.
OC JVM failure is weird, it seems like network error with OpenStack instance |
run tests |
@michalvavrik There are 2 other failures, they goes from other modules and not related to this PR. |
BTW I am adding backport as I either already changed these lines or will change this in PRs that needs to be backported to 1.4.z stream. so I want to avoid conflicts. |
Removing the backport label as this is already in 1.4 branch |
And I am adding the backport label as it turns out that one of the 1.4.2.Beta8 tags actually held 1.4.3.Beta8 release of framework, and I based the 1.4.z branch on that wrongly... |
Removing backport label as this was part of #1105 |
Summary
Sets keystore file type as tests are now failing. See quarkusio/quarkus#39106 and quarkusio/quarkus#39151 for explanation what changed and why it is okay.
Please check the relevant options
run tests
phrase in comment)Checklist: