Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create services for Openshift apps deployed by Quarkus Openshift extension #1041

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Feb 13, 2024

Summary

  1. Create a service for an application, deployed by Quarkus extension, needed due to Openshift extension does not create a service for a management interface quarkusio/quarkus#34645, required for https://issues.redhat.com/browse/QQE-401
  2. Add an option to disable automatic test reruns, Add an option to disable tests reruns #1040

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy
Copy link
Contributor Author

run tests

@fedinskiy fedinskiy linked an issue Feb 13, 2024 that may be closed by this pull request
pom.xml Show resolved Hide resolved
@michalvavrik michalvavrik merged commit a74d132 into main Feb 13, 2024
9 checks passed
@michalvavrik michalvavrik deleted the fix/management-service branch February 13, 2024 12:13
@michalvavrik
Copy link
Member

forgot to comment - changes LGTM, PR name not ideal :-), thanks

@fedinskiy fedinskiy changed the title Fix/management service Create services for Openshift apps deployed by Quarkus Openshift extension Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to disable tests reruns
2 participants