Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection of application classes from test directory in native mode #1014

Conversation

michalvavrik
Copy link
Member

Summary

QE TS daily build in native fails following FW bump. It's consequence of Quarkus Maven plugin build strategy where I didn't take into consideration that app classes selected via annotation (e.g. @QuarkusApplication(classes = ClassicResource.class)) can also come from src/test/java and not only src/main/java

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from mjurc January 24, 2024 14:31
@mjurc
Copy link
Member

mjurc commented Jan 24, 2024

run tests

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this

@michalvavrik
Copy link
Member Author

OCP runs are green. I will merge it.

@michalvavrik michalvavrik merged commit 074e178 into quarkus-qe:main Jan 24, 2024
9 checks passed
@michalvavrik michalvavrik deleted the feature/fix-app-test-classes-selection branch January 24, 2024 16:28
@michalvavrik michalvavrik mentioned this pull request Jan 24, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants