Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom groupId for CLI #486

Closed
fedinskiy opened this issue Jun 15, 2022 · 1 comment · Fixed by #493
Closed

Support custom groupId for CLI #486

fedinskiy opened this issue Jun 15, 2022 · 1 comment · Fixed by #493
Assignees

Comments

@fedinskiy
Copy link
Contributor

Quarkus CLI allows creation of projects with custom groupID(eg."com.mycompany:myproject")[1]. At the same time, method createApplication of QuarkusCliClient does not have api to provide parameters, other than application name. If we attempt to combine name with group id, client fails on buildOnJvm step[2]. Because of that, we can not test issues like quarkusio/quarkus#24713

[1] https://quarkus.io/guides/cli-tooling#project-creation
[2]

    @Test
    public void shouldUseProperModule() throws IOException {
        QuarkusCliRestService app = cliClient.createApplication("com.mycompany:app", defaultWithFixedStream()
                .withExtensions("websockets"));
        Result result = app.buildOnJvm(); // fails with No such file or directory
        assertTrue(result.isSuccessful(), "The application didn't build on JVM. Output: " + result.getOutput());
    
@rsvoboda
Copy link
Member

Sounds like bug in our framework when resolving the directory where the app was created. Probably doesn't expect GAV approach, only astifactId.

@rsvoboda rsvoboda self-assigned this Jun 20, 2022
rsvoboda added a commit to rsvoboda/quarkus-test-framework that referenced this issue Jun 21, 2022
rsvoboda added a commit to rsvoboda/quarkus-test-framework that referenced this issue Jun 21, 2022
rsvoboda added a commit to rsvoboda/quarkus-test-framework that referenced this issue Jun 21, 2022
fedinskiy pushed a commit that referenced this issue Jun 21, 2022
mjurc pushed a commit that referenced this issue Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants