Fix Quarkus-cli flacky test

quarkus-qe · Oct 28, 2021 · 819de5e · 819de5e
1 parent 8cc2cf7
commit 819de5e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 10 deletions.
diff --git a/examples/quarkus-cli/src/test/java/io/quarkus/qe/QuarkusCliClientIT.java b/examples/quarkus-cli/src/test/java/io/quarkus/qe/QuarkusCliClientIT.java
@@ -58,17 +58,22 @@ public void shouldAddAndRemoveExtensions() {
         assertInstalledExtensions(app, RESTEASY_EXTENSION, SMALLRYE_HEALTH_EXTENSION);
 
         // The health endpoint should be now available
-        app.start();
-        untilAsserted(() -> app.given().get("/q/health").then().statusCode(HttpStatus.SC_OK));
+
+        untilAsserted(() -> {
+            app.start();
+            app.given().get("/q/health").then().statusCode(HttpStatus.SC_OK);
+        });
         app.stop();
 
         // Let's now remove the Smallrye Health extension
         result = app.removeExtension(SMALLRYE_HEALTH_EXTENSION);
         assertTrue(result.isSuccessful(), SMALLRYE_HEALTH_EXTENSION + " was not uninstalled. Output: " + result.getOutput());
 
         // The health endpoint should be now gone
-        app.start();
-        untilAsserted(() -> app.given().get("/q/health").then().statusCode(HttpStatus.SC_NOT_FOUND));
+        untilAsserted(() -> {
+            app.start();
+            app.given().get("/q/health").then().statusCode(HttpStatus.SC_NOT_FOUND);
+        });
     }
 
     private void assertInstalledExtensions(QuarkusCliRestService app, String... expectedExtensions) {

diff --git a/quarkus-test-cli/src/test/java/io/quarkus/test/QuarkusCliClientIT.java b/quarkus-test-cli/src/test/java/io/quarkus/test/QuarkusCliClientIT.java
@@ -80,8 +80,10 @@ public void shouldCreateApplicationWithCodeStarter() {
         assertInstalledExtensions(app, RESTEASY_SPRING_WEB_EXTENSION);
 
         // Start using DEV mode
-        app.start();
-        untilAsserted(() -> app.given().get("/greeting").then().statusCode(HttpStatus.SC_OK).and().body(is("Hello Spring")));
+        untilAsserted(() -> {
+            app.start();
+            app.given().get("/greeting").then().statusCode(HttpStatus.SC_OK).and().body(is("Hello Spring"));
+        });
     }
 
     @Test
@@ -100,17 +102,21 @@ public void shouldAddAndRemoveExtensions() {
         assertInstalledExtensions(app, RESTEASY_EXTENSION, SMALLRYE_HEALTH_EXTENSION);
 
         // The health endpoint should be now available
-        app.start();
-        untilAsserted(() -> app.given().get("/q/health").then().statusCode(HttpStatus.SC_OK));
+        untilAsserted(() -> {
+            app.start();
+            app.given().get("/q/health").then().statusCode(HttpStatus.SC_OK);
+        });
         app.stop();
 
         // Let's now remove the Smallrye Health extension
         result = app.removeExtension(SMALLRYE_HEALTH_EXTENSION);
         assertTrue(result.isSuccessful(), SMALLRYE_HEALTH_EXTENSION + " was not uninstalled. Output: " + result.getOutput());
 
         // The health endpoint should be now gone
-        app.start();
-        untilAsserted(() -> app.given().get("/q/health").then().statusCode(HttpStatus.SC_NOT_FOUND));
+        untilAsserted(() -> {
+            app.start();
+            app.given().get("/q/health").then().statusCode(HttpStatus.SC_NOT_FOUND);
+        });
     }
 
     private void assertInstalledExtensions(QuarkusCliRestService app, String... expectedExtensions) {