[2.13] Allow two warnings #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing builder image seems to be fixed now |
rsvoboda
requested changes
Jan 31, 2023
testsuite/src/it/java/io/quarkus/ts/startstop/utils/Commons.java
Outdated
Show resolved
Hide resolved
| import java.util.regex.Pattern; | ||
|
|
||
| public class Commons { | ||
| static Pattern NETTY_HANDLERS=Pattern.compile(".*Could not register io.netty.handler.codec.*"); //https://github.com/quarkusio/quarkus/issues/30508 |
There was a problem hiding this comment.
Better to put it into WhitelistLogLines and drop Commons class
There was a problem hiding this comment.
Moved some more repeated patterns into commons
Fixes failures due to two upstreams issues: Missing classes: quarkusio/quarkus#30508
fedinskiy
force-pushed
the
fix/startstop
branch
from
c4422f9 to
5d91aeb
Compare
fedinskiy
force-pushed
the
fix/startstop
branch
from
5d91aeb to
8a64e30
Compare
Move several repeating patterns to another class
fedinskiy
force-pushed
the
fix/startstop
branch
from
8a64e30 to
79b2b35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failures due to two upstreams issues:
Missing classes: quarkusio/quarkus#30508
Missing builder image: quarkusio/quarkus#30738