Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate @QuarkusTest execution #248

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Separate @QuarkusTest execution #248

merged 1 commit into from
Aug 18, 2021

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented Aug 18, 2021

At some point, maybe this should be put in a shared constant but it
seems a bit too involved to create a shared module just for that.

@gsmet gsmet force-pushed the separate-prod-mode branch 2 times, most recently from 75ba38a to a34e436 Compare August 18, 2021 10:00
@gsmet
Copy link
Contributor Author

gsmet commented Aug 18, 2021

This should make CI green again \o/

@Sgitario Sgitario self-requested a review August 18, 2021 10:17
@rsvoboda
Copy link
Member

@gsmet why does QuarkusProdModeTest need separate surefire execution?

@gsmet
Copy link
Contributor Author

gsmet commented Aug 18, 2021 •
edited
Loading

Because you cannot mix them with @QuarkusTest. It has always been like that and was enforced at some point but the check was removed somehow.

It got reintroduced here: quarkusio/quarkus#19329 and this comment from Stuart: quarkusio/quarkus#19325 (comment) .

@rsvoboda
Copy link
Member

Thanks for details!

@gsmet
Copy link
Contributor Author

gsmet commented Aug 18, 2021

Now that I think of it a bit more, I think we need to isolate the @QuarkusTest not the prod mode as this is the one conflicting.

I'll change the PR and push a PR on core to add a @Tag for @QuarkusTest.

@gsmet gsmet force-pushed the separate-prod-mode branch from a34e436 to 786ef00 Compare August 18, 2021 10:53
@gsmet gsmet changed the title Separate QuarkusProdModeTest execution Separate @QuarkusTest execution Aug 18, 2021
@gsmet
Copy link
Contributor Author

gsmet commented Aug 18, 2021

I adjusted the PR and created quarkusio/quarkus#19477 so that at some point we don't have to tag the tests anymore.

@Sgitario Sgitario mentioned this pull request Aug 18, 2021
Merged
@Sgitario Sgitario merged commit b2d7fdf into quarkus-qe:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sgitario Sgitario Sgitario approved these changes

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @rsvoboda @Sgitario