Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid Vert.x route to prevent app starts #126

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Remove invalid Vert.x route to prevent app starts #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions 304-quarkus-vertx-routes/src/main/java/io/quarkus/qe/BasicsRouteHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,4 @@ public class BasicsRouteHandler {
boolean validateRequestSingleParam(@Param("first_param") String param) {
return true;
}

@Route(methods = HttpMethod.GET, path = "/method-return-empty/:first_param")
void validateMethodWithEmptyResponse(@Param("first_param") String param) {
// do nothing
}
}
10 changes: 0 additions & 10 deletions 304-quarkus-vertx-routes/src/test/java/io/quarkus/qe/BasicsRouteHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import static io.restassured.RestAssured.given;

import org.apache.http.HttpStatus;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import io.quarkus.test.junit.QuarkusTest;
Expand All @@ -18,13 +17,4 @@ public void shouldWorkUsingParamsWithUnderscore() {
.then()
.statusCode(HttpStatus.SC_OK);
}

@Disabled("TODO: Caused by https://github.com/quarkusio/quarkus/issues/15470")
@Test
public void shouldWorkCallingAMethodWithEmptyResponse() {
given().when()
.get("/basics/method-return-empty/work")
.then()
.statusCode(HttpStatus.SC_NO_CONTENT);
}
}