Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv exporter #54

Merged
merged 20 commits into from
Feb 13, 2024
Merged

Add csv exporter #54

merged 20 commits into from
Feb 13, 2024

Conversation

patacca
Copy link
Collaborator

@patacca patacca commented Feb 12, 2024

Fix #30 by adding a csv exporter.

This PR will also come with few changes:

  • Introduce the GenericNode abstract class to define what a "node" in a GenericGraph is. This will replace the previous Item type that was just an alias over Any.
  • Some changes in the API of the Mapping class.
  • Avoid multiple inheritance with classes with different metaclasses on Program. This is related to abstract class instantiable when subclassing built-in types python/cpython#50246
  • Clean code and better typing support

Still missing:

  • Add documentation in diffing-portal about the new exporter
  • Make the csv exporter as the default one in the CLI
  • Change the README.md help description

@patacca patacca added enhancement New feature or request refactoring Refactoring part of the code labels Feb 12, 2024
@patacca patacca marked this pull request as ready for review February 13, 2024 10:21
@patacca
Copy link
Collaborator Author

patacca commented Feb 13, 2024

PR ready for review

@RobinDavid
Copy link
Collaborator

Sounds great for me!

@RobinDavid RobinDavid merged commit e601217 into main Feb 13, 2024
@patacca patacca deleted the add_csv_exporter branch February 14, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Refactoring part of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CSV exporter
2 participants