Fix building issues with Python 3.11. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix building issues with Python 3.11.
|
Should fix #13 |
Fix build issue from sources with Python 3.11 (do not install binexport and only module). Follow guidelines and recommandations provided by setuptools documentation to insure cross platform compatibility
|
Addition: transform bin script into an entrypoint (details of why provided in the commit message) Moreover, installation has been tested for Python 3.9. Install works well but |
|
I fixed a couple of small things but for the rest LGTM. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
setup.pyas it only contain info that should be in thepyproject.tomlaccording to the last pip guidelines and also to fix the building issues with Python 3.11.