Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider a custom extractor to have a custom userId #113

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

srose
Copy link
Contributor

@srose srose commented Mar 13, 2024

fix #95

(draft, lets discuss)

@kdubb
Copy link
Contributor

kdubb commented Apr 2, 2024

@srose Sorry about the delay. I'm looking into this soon. I like the general idea.

@kdubb kdubb force-pushed the feat/95-custom-userId-extractor branch from 1de8ed0 to 7d05c55 Compare April 2, 2024 18:47
@kdubb
Copy link
Contributor

kdubb commented Apr 2, 2024

@srose I simplified the auth filter using Optional.map and Optional.or. Also I renamed some things to userId to be explicit where a user-id, user-type and compound user is expected.

@srose
Copy link
Contributor Author

srose commented Apr 3, 2024

@kdubb thanks for having a look. The changes you did make perfect sense to me.

@kdubb kdubb force-pushed the feat/95-custom-userId-extractor branch from e28d3de to 76bb93a Compare April 19, 2024 19:17
@kdubb kdubb merged commit 733edfa into quarkiverse:main Apr 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an option to have a custom principal.getName() extractor
2 participants