Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize ImageType at Build Time #169

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

melloware
Copy link
Contributor

@melloware melloware commented Nov 8, 2023

@gastaldi just seeing if this works...

Fix #168

@melloware melloware marked this pull request as draft November 8, 2023 16:32
@gastaldi
Copy link
Member

gastaldi commented Nov 8, 2023

I did the same yesterday and got an image build deadlock, but maybe because I ran in an Ubuntu VM with 8Gb RAM

@melloware melloware marked this pull request as ready for review November 8, 2023 16:47
@melloware melloware requested a review from gastaldi November 8, 2023 16:47
@melloware
Copy link
Contributor Author

Looks like it worked today!

@melloware melloware added the bug Something isn't working label Nov 8, 2023
@melloware melloware added this to the 2.0.3 milestone Nov 8, 2023
@gastaldi
Copy link
Member

gastaldi commented Nov 8, 2023

You need to test with the latest Quarkus 999-SNAPSHOT (as the ecosystem CI does).

Maybe we can merge this and see how it goes

@melloware
Copy link
Contributor Author

Oh right I forgot it's the nightly build. Let's merge and cross our fingers?

@melloware melloware merged commit 8208eec into main Nov 8, 2023
1 check passed
@melloware melloware deleted the melloware-pdfbox-imagetype branch November 8, 2023 17:12
@gastaldi
Copy link
Member

gastaldi commented Nov 8, 2023

Grab some popcorn and let's sit back and watch: https://github.com/quarkiverse/quarkus-tika/actions/runs/6801700484/job/18493148295 :)

fedinskiy added a commit to fedinskiy/quarkus-quickstarts that referenced this pull request Apr 11, 2024
Otherwise it fail in Native mode
See quarkiverse/quarkus-tika#169 for details
Backport of quarkusio@aa095b4
fedinskiy added a commit to fedinskiy/quarkus-quickstarts that referenced this pull request Apr 11, 2024
Otherwise it fails in Native mode
See quarkiverse/quarkus-tika#169 for details
Backport of quarkusio@aa095b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants