Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Series #302

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Plugin Series #302

merged 5 commits into from
Dec 5, 2024

Conversation

jtama
Copy link
Member

@jtama jtama commented Dec 2, 2024

fixes #294

@jtama jtama requested a review from a team as a code owner December 2, 2024 15:37
@ia3andy
Copy link
Contributor

ia3andy commented Dec 2, 2024

@jtama could you rebase?

@ia3andy
Copy link
Contributor

ia3andy commented Dec 2, 2024

ah sorry you did :)

Copy link

github-actions bot commented Dec 2, 2024

🙈 The PR is closed and the preview is expired.

@jtama
Copy link
Member Author

jtama commented Dec 2, 2024

Yes, I sometimes forget to sync repositories.

And I forgot to say that I am NOT a front developer ;)

@jtama jtama force-pushed the plugin-serie branch 2 times, most recently from 0ccff35 to 0e48eb2 Compare December 2, 2024 16:34
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will let others review too

@jtama
Copy link
Member Author

jtama commented Dec 3, 2024

Ok I think there's something to do with @datamapping, I thought it would automatically register my record for reflexion, but it does so only if there is a RoqDataBuildItem linked to it. It's not the case for me, the data is generated through a recorder.

Anyway, I fixed the native build, but I had a small talk with @ia3andy who will help for ui design, mine is really, really poor.

@ia3andy ia3andy changed the title Plugin serie Plugin Series Dec 5, 2024
@ia3andy
Copy link
Contributor

ia3andy commented Dec 5, 2024

At some point it might make sense to allow having more stuff to the FM series to define sorting, if it's ordered or not and other stuff...

@ia3andy ia3andy merged commit ce6a271 into quarkiverse:main Dec 5, 2024
4 checks passed
jtama added a commit to jtama/quarkus-roq that referenced this pull request Dec 6, 2024
Add Series Plugin

---------

Co-authored-by: Andy Damevin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give the ability to make posts series
4 participants