made time and timezone optional #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ia3andy
reviewed
Oct 7, 2024
...rc/main/java/io/quarkiverse/roq/frontmatter/deployment/scan/RoqFrontMatterScanProcessor.java
Outdated
Show resolved
Hide resolved
ia3andy
reviewed
Oct 7, 2024
...rc/main/java/io/quarkiverse/roq/frontmatter/deployment/scan/RoqFrontMatterScanProcessor.java
Outdated
Show resolved
Hide resolved
ia3andy
reviewed
Oct 7, 2024
...rc/main/java/io/quarkiverse/roq/frontmatter/deployment/scan/RoqFrontMatterScanProcessor.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@all-contributors add @edewit for code |
|
I've put up a pull request to add @edewit! 🎉 |
ia3andy
reviewed
Oct 8, 2024
...deployment/src/main/java/io/quarkiverse/roq/frontmatter/deployment/RoqFrontMatterConfig.java
Outdated
Show resolved
Hide resolved
ia3andy
approved these changes
Oct 8, 2024
ia3andy
reviewed
Oct 8, 2024
...deployment/src/main/java/io/quarkiverse/roq/frontmatter/deployment/RoqFrontMatterConfig.java
Outdated
Show resolved
Hide resolved
ia3andy
reviewed
Oct 8, 2024
...deployment/src/main/java/io/quarkiverse/roq/frontmatter/deployment/RoqFrontMatterConfig.java
Outdated
Show resolved
Hide resolved
improved parsing of date now time and timezone are optional fixes: quarkiverse#134
melloware
approved these changes
Oct 8, 2024
|
🙈 The PR is closed and the preview is expired. |
mcruzdev
pushed a commit
that referenced
this pull request
Oct 9, 2024
made time and timezone optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #134