Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for redirect with aliases #124

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Conversation

mcruzdev
Copy link
Member

@mcruzdev mcruzdev commented Sep 28, 2024

In this pull request we are adding a way to add a alias to frontmatter, it is great when you want to use a shorten link for sharing.

Fixes #77

Copy link

github-actions bot commented Oct 5, 2024

🙈 The PR is closed and the preview is expired.

@mcruzdev mcruzdev reopened this Oct 5, 2024
@mcruzdev mcruzdev force-pushed the issue-77 branch 3 times, most recently from 667b683 to 6f46f5f Compare October 5, 2024 20:44
@mcruzdev mcruzdev marked this pull request as ready for review October 5, 2024 20:46
@mcruzdev mcruzdev requested a review from a team as a code owner October 5, 2024 20:46
@mcruzdev
Copy link
Member Author

mcruzdev commented Oct 5, 2024

@ia3andy I don't know if that's what you was thinking, suggestions for improvements are welcome!

cc: @melloware

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have this as a plugin instead? (The migration is easy)
Could we have the doc (maybe add a plugins doc page and I will also add the tagging doc there)?

@mcruzdev
Copy link
Member Author

mcruzdev commented Oct 8, 2024

Would it make sense to have this as a plugin instead? (The migration is easy) Could we have the doc (maybe add a plugins doc page and I will also add the tagging doc there)?

Yeah, it makes sense!

@mcruzdev mcruzdev force-pushed the issue-77 branch 2 times, most recently from 4948654 to d9663c4 Compare October 8, 2024 21:34
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcruzdev mcruzdev merged commit c28bfd6 into quarkiverse:main Oct 9, 2024
2 checks passed
@mcruzdev mcruzdev deleted the issue-77 branch October 9, 2024 14:18
@mcruzdev mcruzdev restored the issue-77 branch October 9, 2024 14:21
@mcruzdev mcruzdev deleted the issue-77 branch October 9, 2024 14:44
mcruzdev added a commit that referenced this pull request Oct 9, 2024
Add support for redirect with aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontmatter] Add support for redirect
2 participants