Fix NullPointerException that would occur when WebApplicationExceptio…

…n was thrown with an unassigned Http Status Code (#443) Co-authored-by: JacobOJ <github.com/JacobOJ>
quarkiverse · Nov 19, 2024 · 5dc7151 · 5dc7151
1 parent c521113
commit 5dc7151
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/integration-test/src/test/java/io/quarkiverse/resteasy/problem/JaxRsMappersIT.java b/integration-test/src/test/java/io/quarkiverse/resteasy/problem/JaxRsMappersIT.java
@@ -6,6 +6,7 @@
 import static jakarta.ws.rs.core.Response.Status.NOT_FOUND;
 import static org.hamcrest.CoreMatchers.endsWith;
 import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.Matchers.equalToIgnoringCase;
 import static org.hamcrest.Matchers.nullValue;
 
 import io.quarkus.test.junit.QuarkusTest;
@@ -38,6 +39,19 @@ void webApplicationExceptionShouldReturnGivenStatus(int status) {
                 .body("stacktrace", nullValue());
     }
 
+    @ParameterizedTest(name = "http status: {0}")
+    @ValueSource(ints = { 318, 499, 533 })
+    void webApplicationExceptionWithUnassignedHttpStatusCodeShouldNotFail(int status) {
+        given()
+            .queryParam("status", status)
+            .get("/throw/jax-rs/web-application-exception")
+            .then()
+            .statusCode(status)
+            .body("title", equalToIgnoringCase("Unknown Code"))
+            .body("status", equalTo(status))
+            .body("stacktrace", nullValue());
+    }
+
     @Test
     void webApplicationExceptionShouldReturnHeaders() {
         int status = 429;

diff --git a/...me/src/main/java/io/quarkiverse/resteasy/problem/jaxrs/WebApplicationExceptionMapper.java b/...me/src/main/java/io/quarkiverse/resteasy/problem/jaxrs/WebApplicationExceptionMapper.java
@@ -18,7 +18,7 @@ public final class WebApplicationExceptionMapper extends ExceptionMapperBase<Web
 
     @Override
     protected HttpProblem toProblem(WebApplicationException exception) {
-        Response.StatusType status = Response.Status.fromStatusCode(exception.getResponse().getStatus());
+        Response.StatusType status = exception.getResponse().getStatusInfo();
 
         HttpProblem.Builder problem = HttpProblem.builder()
                 .withTitle(status.getReasonPhrase())
@@ -32,5 +32,4 @@ protected HttpProblem toProblem(WebApplicationException exception) {
 
         return problem.build();
     }
-
 }