Skip to content

Commit

Permalink
Merge pull request #184 from gbourant/logout
Browse files Browse the repository at this point in the history
remove cookie correctly
  • Loading branch information
FroMage authored Jan 3, 2024
2 parents 3d61842 + f010a1b commit b35a879
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ private void assertRedirectWithMessage(String token, String message) {
.getValues("Set-Cookie")
.stream().filter(c -> c.startsWith("QuarkusUser=")).findFirst().get();

Assertions.assertEquals("QuarkusUser=;Version=1;Max-Age=0", quarkusUserCookie);
Assertions.assertEquals("QuarkusUser=;Version=1;Path=/;Max-Age=0", quarkusUserCookie);

String flash = response.cookie(Flash.FLASH_COOKIE_NAME);
Map<String, Object> data = Flash.decodeCookieValue(flash);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ private void verifyLoggedInAndLogout(RenardeCookieFilter cookieFilter, String co
.getValues("Set-Cookie")
.stream().filter(c -> c.startsWith("QuarkusUser=")).findFirst().get();

Assertions.assertEquals("QuarkusUser=;Version=1;Max-Age=0", logoutCookie);
Assertions.assertEquals("QuarkusUser=;Version=1;Path=/;Max-Age=0", logoutCookie);

}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ private Response redirectToRoot(String message) {
}

public static NewCookie invalidateCookie(String cookieName) {
return new NewCookie.Builder(cookieName).maxAge(0).build();
return new NewCookie.Builder(cookieName).path("/").maxAge(0).build();
}

}

0 comments on commit b35a879

Please sign in to comment.