Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Quarkus 3.3.0 #39

Closed
ia3andy opened this issue Aug 25, 2023 · 5 comments
Closed

With Quarkus 3.3.0 #39

ia3andy opened this issue Aug 25, 2023 · 5 comments

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Aug 25, 2023

2023-08-24 09:52:55,652 ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (vert.x-eventloop-thread-4) HTTP Request to / failed, error id: 725c1659-8bb1-4579-882a-5f2c5e765f56-1: java.lang.NoSuchMethodError: 'void io.quarkus.arc.ManagedContext.activate()'
    at io.quarkiverse.quteserverpages.runtime.QspHandler.handle(QspHandler.java:82)
    at io.quarkiverse.quteserverpages.runtime.QspHandler.handle(QspHandler.java:36)
    at io.vertx.ext.web.impl.BlockingHandlerDecorator.lambda$handle$0(BlockingHandlerDecorator.java:48)
    at io.vertx.core.impl.ContextBase.lambda$null$0(ContextBase.java:137)
    at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:264)
    at io.vertx.core.impl.ContextBase.lambda$executeBlocking$1(ContextBase.java:135)
    at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
    at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
    at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
    at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
    at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
    at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
    at java.base/java.lang.Thread.run(Thread.java:833)
@gsmet
Copy link
Member

gsmet commented Aug 25, 2023

The return value of the method changed. The extension needs to be recompiled for 3.3.

Do it in a minor as we need to keep a version compatible with 3.2.

@mkouba
Copy link
Contributor

mkouba commented Aug 29, 2023

Unfortunately, quarkusio/quarkus#35246 (main, aka 3.4) will break the QspHandler again.

Do it in a minor as we need to keep a version compatible with 3.2.

@gsmet What do you mean with "do it in a minor"? We can't recompile against 3.3 and keep the 3.2 as the target. I'm going to:

  1. Create a 2.0.x branch (targets 3.2)
  2. Main will target Quarkus 3.3
  3. Release 2.1.0 targeting 3.3

@mkouba
Copy link
Contributor

mkouba commented Aug 29, 2023

For the record - this particular compatibility issue should be fixed in quarkusio/quarkus#35615 and the fix should be backported in the next 3.3 bugfix release. But we will release the QSP 2.1.0 anyway...

@gsmet
Copy link
Member

gsmet commented Aug 29, 2023

Create a 2.0.x branch (targets 3.2)
Main will target Quarkus 3.3
Release 2.1.0 targeting 3.3

Exactly what I had in mind.

@mkouba
Copy link
Contributor

mkouba commented Aug 29, 2023

@mkouba mkouba closed this as completed Aug 29, 2023
mcruzdev pushed a commit to mcruzdev/quarkus-qute-web that referenced this issue Oct 9, 2024
…o.quarkiverse.web-bundler-quarkus-web-bundler-1.7.0

Bump io.quarkiverse.web-bundler:quarkus-web-bundler from 1.6.0 to 1.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants