[2.3.x] Add root path for Quinoa Web UI #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the quarkus.quinoa.ui-root-path property which is the path for hosting the Web UI. The quarkus.quinoa.ignored-path-prefixes property is always relative to quarkus.quinoa.ui-root-path. The quarkus.http.non-application-root-path is not added to the default ignores if it is not relative to quarkus.http.root-path.
4 tasks
melloware
approved these changes
Jun 17, 2024
|
I will wait for @ia3andy review and once its all done I will cut a 2.3.X release with your great fix! |
|
I will not have time today, if you tested it @melloware I approve the code part |
|
@liquidnya congratulation for getting this in, this is a very nice contribution and thank you 🚀🎉 |
|
@liquidnya would you care to join the quarkus zulip? |
|
I tried to cut a release of 2.3 but it failed for Quarkus invalid token which Max is fixing I will try again today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is a back-port of #691 to the
2.3.xbranch.Note that if the
quarkus.quinoa.ui-root-path=/foois set, thenhttp://localhost:8080/fooredirects tohttp://localhost:8080/foo/to serve theindex.htmlfile in production mode.This happens, because in production mode
io.vertx.ext.web.handler.StaticHandleris used to serve files which already implements this behavior.Fixes Issue
Fixes #302
Check List (Check all the applicable boxes)