[Breaking][Requires Quarkus 3.12+] Use new generated static resources #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mcruzdev your new stuff again :) |
|
@melloware since this is for 3.12+ maybe we should start a new branching for backports? |
|
I will cut the 2.3.8 release and make a 2.3.X branch so we can start this new version as 2.4.0 |
melloware
force-pushed
the
generated-static-resources
branch
from
bd1dddc to
b2aed60
Compare
melloware
approved these changes
Jun 13, 2024
melloware
force-pushed
the
generated-static-resources
branch
from
b2aed60 to
1e59a8b
Compare
mcruzdev
reviewed
Jun 17, 2024
| import static io.quarkiverse.quinoa.deployment.config.QuinoaConfig.isDevServerMode; | ||
| import static io.quarkiverse.quinoa.deployment.config.QuinoaConfig.isEnabled; | ||
| import static io.quarkiverse.quinoa.deployment.config.QuinoaConfig.toHandlerConfig; | ||
| import static io.quarkiverse.quinoa.deployment.config.QuinoaConfig.*; |
There was a problem hiding this comment.
i am fixing in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change Quinoa is finally able to delegate file server to Quarkus Vert.x http using the new GeneratedStaticResourceBuildItem.
quarkus.quinoa.index-pagehas been removed. Usequarkus.http.static-resources.index-pageinstead.