Fix dev service restart condition #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently dev mode will restart the dev service every time, significantly increasing hot reload time.
melloware
approved these changes
Dec 19, 2023
|
Ohh snap, this is a regression when switching to interface for configs. I thought the implementation provided would have implemented those :-/ I think this should also be fixed to have the interface implementation with the equals and hashcode. |
|
Thanks for catching and fixing this @stuartwdouglas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dev mode will restart the dev service every time, significantly increasing hot reload time.
Currently the config does not implement equals, so the equals check is based on object equality and will always result in a restart of the dev service.