Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #46: Add new Dev UI #272

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Fix #46: Add new Dev UI #272

merged 6 commits into from
Mar 21, 2023

Conversation

melloware
Copy link
Contributor

Fix #46: Add new Dev UI

image

@melloware melloware force-pushed the devui-46 branch 2 times, most recently from cd1a33c to 16a3f8a Compare March 13, 2023 17:02
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the only reason for the custom card is the logo ?

@melloware
Copy link
Contributor Author

So the only reason for the custom card is the logo ?

Yes pretty much and to shorten the description.

@phillip-kruger
Copy link
Member

ok cool, make sense. I think we should add logo/icon to the yaml, but if you need a custom card anyway, then this is good. From my p.o.v this is ok to merge, but I'll let @ia3andy do the final review

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phillip-kruger phillip-kruger requested a review from ia3andy March 14, 2023 11:32
@melloware
Copy link
Contributor Author

Yes I think we need the logo in the YAML but wasn't sure I would be able to submit a PR that allows a new property in the YAML file? quarkusio/quarkus#31785

@phillip-kruger
Copy link
Member

I'll start a discussion and see if we can get it done. For now this is good. Thanks :)

@ia3andy
Copy link
Collaborator

ia3andy commented Mar 16, 2023

@melloware CI is failing

@melloware
Copy link
Contributor Author

@ia3andy Yeah everything works in 3.0.0.Alpha4 but as soon as you change to Alpha5 or Alpha6 a unit test fails with Expected status code <404> but was <405> without any code changes so I am not sure if something changed in Vert.X or not but didn't want to just change the test to be a 405?

@melloware
Copy link
Contributor Author

OK I fixed the 404 to 405 but now other tests are failing downloading the NPM binaries? Not sure if its github action related or not?

@melloware
Copy link
Contributor Author

running locally in Windows I get this failure.

Caused by: java.lang.RuntimeException: Error in Quinoa while running package manager install command: pnpm.cmd install
        at io.quarkiverse.quinoa.deployment.packagemanager.PackageManager.install(PackageManager.java:47)
        at io.quarkiverse.quinoa.deployment.QuinoaProcessor.prepareQuinoaDirectory(QuinoaProcessor.java:108)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
        at java.base/java.lang.Thread.run(Thread.java:833)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)

@ia3andy
Copy link
Collaborator

ia3andy commented Mar 17, 2023

@melloware sorry, the 405 bug was not your doing, I created an issue for it: quarkusio/quarkus#31928

@melloware
Copy link
Contributor Author

Thank you! I will revert my 404 to 405 change.

@melloware
Copy link
Contributor Author

@ia3andy where did we land on this? I couldn't follow the argument about the 404 vs 405 😄

@ia3andy
Copy link
Collaborator

ia3andy commented Mar 20, 2023

@ia3andy where did we land on this? I couldn't follow the argument about the 404 vs 405 😄

#278 added the fix to the bump PR, waiting for CI

@ia3andy
Copy link
Collaborator

ia3andy commented Mar 20, 2023

@melloware the CI is still failing any idea why?

@melloware
Copy link
Contributor Author

I am investigating...

@melloware
Copy link
Contributor Author

OK all passing now!

@ia3andy
Copy link
Collaborator

ia3andy commented Mar 21, 2023

@melloware all is good, the only weird thing is when clicking on items, it leads to an empty page..
image

@melloware
Copy link
Contributor Author

melloware commented Mar 21, 2023

Yep open bug I reported to Phillip quarkusio/quarkus#31786

@phillip-kruger
Copy link
Member

I'll fix it soon

Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @melloware for those awesome contrib!

@ia3andy ia3andy merged commit d684985 into quarkiverse:main Mar 21, 2023
@melloware melloware deleted the devui-46 branch March 21, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dev-ui panel
3 participants