-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #46: Add new Dev UI #272
Conversation
cd1a33c
to
16a3f8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the only reason for the custom card is the logo ?
Yes pretty much and to shorten the description. |
ok cool, make sense. I think we should add logo/icon to the yaml, but if you need a custom card anyway, then this is good. From my p.o.v this is ok to merge, but I'll let @ia3andy do the final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Yes I think we need the logo in the YAML but wasn't sure I would be able to submit a PR that allows a new property in the YAML file? quarkusio/quarkus#31785 |
I'll start a discussion and see if we can get it done. For now this is good. Thanks :) |
@melloware CI is failing |
@ia3andy Yeah everything works in 3.0.0.Alpha4 but as soon as you change to Alpha5 or Alpha6 a unit test fails with |
OK I fixed the 404 to 405 but now other tests are failing downloading the NPM binaries? Not sure if its github action related or not? |
running locally in Windows I get this failure.
|
@melloware sorry, the 405 bug was not your doing, I created an issue for it: quarkusio/quarkus#31928 |
Thank you! I will revert my 404 to 405 change. |
@ia3andy where did we land on this? I couldn't follow the argument about the 404 vs 405 😄 |
@melloware the CI is still failing any idea why? |
I am investigating... |
OK all passing now! |
@melloware all is good, the only weird thing is when clicking on items, it leads to an empty page.. |
Yep open bug I reported to Phillip quarkusio/quarkus#31786 |
I'll fix it soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @melloware for those awesome contrib!
Fix #46: Add new Dev UI