Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You need the host & port for vite hmr websocket #245

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

ebullient
Copy link
Contributor

No description provided.

@ia3andy
Copy link
Collaborator

ia3andy commented Mar 7, 2023

@ebullient what I don't get is that this actually works for me without setting this.

Before giving the instruction in the doc, it would be nice to understand why it behaves differently.

@melloware
Copy link
Contributor

I think I just opened a similar ticket about HMR in NExt JS: #268

@melloware
Copy link
Contributor

I can confirm without these changes the current documentation just forces Vite to reload over and over again. This changes makes it work.

Here is a runnable reproducer: quinoa-vite.zip

Just run mvn quarkus:dev and it works.

@ia3andy ia3andy merged commit 32459c6 into main Mar 10, 2023
@ia3andy ia3andy deleted the ebullient-patch-1 branch March 10, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants