Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runtime diagram to reflect recent routing changes #715

Closed
ia3andy opened this issue Jul 12, 2024 · 3 comments · Fixed by #717
Closed

Update runtime diagram to reflect recent routing changes #715

ia3andy opened this issue Jul 12, 2024 · 3 comments · Fixed by #717
Assignees
@melloware
Labels
documentation Improvements or additions to documentation feature good first issue Good for newcomers
Milestone
2.4.2

Comments

@ia3andy
Copy link
Collaborator

ia3andy commented Jul 12, 2024

Now, Quinoa is not in charge of the route to serve the static files anymore, this is done by Quarkus Http. This should be reflected in the doc: https://docs.quarkiverse.io/quarkus-quinoa/dev/main-concepts.html#_runtime_for_production_mode

Source is here:
https://github.com/quarkiverse/quarkus-quinoa/blob/main/docs/modules/ROOT/assets/images/quinoa-runtime-prod.excalidraw
@ia3andy ia3andy added feature documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 12, 2024
@melloware
Copy link
Contributor

@ia3andy i made the change but before I submit the PR can you verify this is correct?

image

@melloware melloware self-assigned this Jul 13, 2024
@melloware melloware added this to the 2.4.2 milestone Jul 13, 2024
@melloware
Copy link
Contributor

Or should I remove quinoa entirely from the diagram?

@ia3andy
Copy link
Collaborator Author

ia3andy commented Jul 15, 2024

Or should I remove quinoa entirely from the diagram?

Yes remove it and rename META-INF/resources by Static Resources handler

melloware added a commit to melloware/quarkus-quinoa that referenced this issue Jul 15, 2024
@melloware
Fix quarkiverse#715: Update runtime production drawing
c2fbefc
@melloware melloware mentioned this issue Jul 15, 2024
Merged
melloware added a commit to melloware/quarkus-quinoa that referenced this issue Jul 15, 2024
@melloware
Fix quarkiverse#715: Update runtime production drawing
62989e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
documentation Improvements or additions to documentation feature good first issue Good for newcomers
Projects
None yet
Milestone
2.4.2
Development

Successfully merging a pull request may close this issue.

Fix #715: Update runtime production drawing melloware/quarkus-quinoa
2 participants
@ia3andy @melloware