Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to define if dev-server is HTTPS / TLS #682

Closed
ylemoigne opened this issue Jun 5, 2024 · 5 comments · Fixed by #684
Closed

Allow to define if dev-server is HTTPS / TLS #682

ylemoigne opened this issue Jun 5, 2024 · 5 comments · Fixed by #684
Assignees
@ylemoigne
Labels
feature good first issue Good for newcomers
Milestone
2.3.8

Comments

@ylemoigne
Copy link
Contributor

Feature idea

Currently, dev-server host and port are configurable.
But not the protocol. Please add support for https.

Additional information

With the current situation :
If quarkus is used in https and angular is in http, the webapp will try to connect to wss://host/ng-cli-ws (and fail because ng serve is configured in http).
If quarkus is used in https and angular is in https, quinoa dev-server won't work.
@melloware melloware added good first issue Good for newcomers feature and removed feature good first issue Good for newcomers labels Jun 6, 2024
@melloware
Copy link
Contributor

@ylemoigne have you researched this at all? It seems like a good first issue for a PR!

@melloware melloware added the good first issue Good for newcomers label Jun 6, 2024
ylemoigne added a commit to ylemoigne/quarkus-quinoa that referenced this issue Jun 12, 2024
@ylemoigne
Fix quarkiverse#682: Allow to define if dev-server is HTTPS / TLS
0cce468
@melloware melloware mentioned this issue Jun 12, 2024
Merged
@melloware melloware added this to the 2.3.8 milestone Jun 12, 2024
@melloware
Copy link
Contributor

@all-contributors add @ylemoigne for code

@allcontributors allcontributors bot mentioned this issue Jun 12, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@melloware

I've put up a pull request to add @ylemoigne! 🎉

ylemoigne added a commit to ylemoigne/quarkus-quinoa that referenced this issue Jun 12, 2024
@ylemoigne
Fix quarkiverse#682: Pass formatter
cb5251f
melloware pushed a commit that referenced this issue Jun 13, 2024
@ylemoigne
Fix #682: Allow to define if dev-server is HTTPS / TLS (#684)
dc9c997 
* Fix #682: Allow to define if dev-server is HTTPS / TLS

* Fix #682: Pass formatter
@melloware melloware modified the milestones: 2.4.0, 2.3.8 Jun 13, 2024
@melloware
Copy link
Contributor

2.3.8 has been released and should be in maven central in the next hour

@ylemoigne
Copy link
Contributor Author

Nice. Thanks you.

ylemoigne added a commit to ylemoigne/quarkus-quinoa that referenced this issue Jun 15, 2024
@ylemoigne
Fix quarkiverse#682: Add tls support to the real forwarder
80822ab
ylemoigne added a commit to ylemoigne/quarkus-quinoa that referenced this issue Jun 15, 2024
@ylemoigne
Fix quarkiverse#682: Update documentation
8028c4a
@ylemoigne ylemoigne mentioned this issue Jun 15, 2024
Merged
3 tasks
ylemoigne added a commit to ylemoigne/quarkus-quinoa that referenced this issue Jun 15, 2024
@ylemoigne
Fix quarkiverse#682: Add tls support to real forwarder
e2f7949
ylemoigne added a commit to ylemoigne/quarkus-quinoa that referenced this issue Jun 15, 2024
@ylemoigne
Fix quarkiverse#682: Pass formatter on runtime module
abb726f
melloware pushed a commit that referenced this issue Jun 15, 2024
@ylemoigne
Fix #682: Allow to define if dev-server is HTTPS / TLS (Again) (#692)
30d7fc5 
* Fix #682: Add tls support to real forwarder

* Fix #682: Pass formatter on runtime module
melloware added a commit to melloware/quarkus-quinoa that referenced this issue Jun 15, 2024
@melloware
Fix quarkiverse#682: 2.3.x Allow to define if dev-server is HTTPS / TLS
2cdeb52
@melloware melloware mentioned this issue Jun 15, 2024
Merged
melloware added a commit to melloware/quarkus-quinoa that referenced this issue Jun 15, 2024
@melloware
Fix quarkiverse#682: 2.3.x Allow to define if dev-server is HTTPS / TLS
da2c6a0
melloware added a commit that referenced this issue Jun 15, 2024
@melloware
Fix #682: 2.3.x Allow to define if dev-server is HTTPS / TLS (#694)
8e8a25e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ylemoigne ylemoigne

Labels
feature good first issue Good for newcomers
Projects
None yet
Milestone
2.3.8
Development

Successfully merging a pull request may close this issue.

Fix #682: Allow to define if dev-server is HTTPS / TLS ylemoigne/quarkus-quinoa
2 participants
@ylemoigne @melloware