Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Quarkus 3 toleration #76

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Feb 10, 2023

Quarkus 3 brings two major changes - the javax/jakarta namespace change, and a change to classloading. Quarkus 2 core defined many pact modules to be parentfirst. In Quarkus 3, that will be done by this extension. The Quarkus 3 kotlin extension also stopped loading kotlin parent first.

Consumer
I was able to remove all the parent-first dependencies for the consumer.

Provider
For the provider, oddly, I had it working with a single parent-first dependency (one pact library) in December, but now I needed the full set. I think that's because of the reversion of quarkusio/quarkus#29785 between when I first did the work and now.

I will continue working to see if I can reduce it down to a minimal set, or having both extensions in the same project will be a problem. Ideally, the provider would work without any parent first dependencies, but that is a bigger piece of work.

I did have to disable one test, and have raised #73 to reflect the failing test, but I think #73 is not a serious issue.

@holly-cummins
Copy link
Contributor Author

holly-cummins commented Feb 10, 2023

Also, with the classloading changes in Quarkus 3, it looks like neither quarkusio/quarkus#30238 nor quarkusio/quarkus#30383 are needed for consumer tests to work in dev mode.

With the classloading changes in Quarkus 3, it looks like neither quarkusio/quarkus#30238 nor quarkusio/quarkus#30383 are needed (at least for the consumer tests, in the current state).
@holly-cummins holly-cummins merged commit f0fb5d9 into quarkiverse:main Feb 17, 2023
@holly-cummins holly-cummins deleted the pact-for-quarkus-3 branch February 17, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant