Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler to be used by the Azure endpoints #195

Merged
merged 8 commits into from
Jul 16, 2024

Conversation

brunobat
Copy link
Collaborator

@brunobat brunobat commented Jul 11, 2024

Sampler to allow not sending traces for the azure target endpoint

brunobat and others added 8 commits July 11, 2024 12:54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
.until(telemetryDataContainTheHttpCall(wireMockServer));

// Non regression test for https://github.com/Azure/azure-sdk-for-java/issues/41040
Thread.sleep(10_000);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of time... You can speed up batch exports by setting quarkus.otel.bsp.schedule.delay=100, or some really tight value for this particular test.
It's probably better to create a new test class for this issue, with a custom test profile, that would set that property for you.

@Override
public AzureEndpointSampler apply(SyntheticCreationalContext<AzureEndpointSampler> context) {
List<String> ingestionUrls = findIngestionUrls(runtimeConfig, quarkusRuntimeConfig);
List<String> statsBeatUrls = Arrays.asList("https://westeurope-5.in.applicationinsights.azure.com/",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these addresses be retrieved from somewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. These are default end points. They are not in the connection string.

@brunobat brunobat marked this pull request as ready for review July 16, 2024 15:22
@brunobat brunobat requested a review from jeanbisutti July 16, 2024 15:22
@brunobat brunobat merged commit 8da3553 into quarkiverse:main Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants