Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add blank Bearer token #588

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

martinoneutrino
Copy link
Contributor

@martinoneutrino martinoneutrino commented Dec 12, 2023

Request for BearerAuthenticationProvider not to add a blank token to the Authorization header, as doing so will never satisfy any real authorization requirement, and may cause a request failure when multiple Authorization headers are sent due to multiple (optional) security schemes are defined on an endpoint.

This change could be extended to the other AuthProviders, but I have not been using those.

Fixes: #589

hbelmiro
hbelmiro approved these changes Dec 13, 2023
@hbelmiro hbelmiro merged commit ddd9013 into quarkiverse:main Dec 13, 2023
12 checks passed
@hbelmiro
Copy link
Contributor

@all-contributors add @martinoneutrino to code.

github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
Copy link
Contributor

@hbelmiro

I've put up a pull request to add @martinoneutrino! 🎉

hbelmiro pushed a commit that referenced this pull request Dec 13, 2023
Co-authored-by: Martin <[email protected]>
Co-authored-by: Martin Glass <[email protected]>
@martinoneutrino martinoneutrino deleted the bearer-only-non-blank branch January 31, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not add blank Bearer token
3 participants