Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Dev UI card #242

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Add new Dev UI card #242

merged 1 commit into from
Jun 21, 2023

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Jun 21, 2023

Screenshot_20230620_175823

Fix #208

@phillip-kruger
Copy link
Member Author

@jtama please have a look


@BuildStep(onlyIf = IsDevelopment.class)
void createCard(BuildProducer<CardPageBuildItem> cardProducer, MinioBuildTimeConfig devServiceConfig,
MiniosBuildTimeConfiguration configuration) {

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'configuration' is never used.
nbactions.xml Outdated Show resolved Hide resolved
Signed-off-by: Phillip Kruger <[email protected]>
@jtama
Copy link
Member

jtama commented Jun 21, 2023

LGTM.

WIll merge as soon as the build is green.

@jtama jtama merged commit 7b0dd0f into quarkiverse:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to the new Dev UI
2 participants