Upgrade to quarkus-amazon-services 2.4.2 and migrate to @ConfigMapping #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `quarkus-amazon-services.version` from 2.4.0 to 2.4.2. Updates `io.quarkiverse.amazonservices:quarkus-amazon-services-bom` from 2.4.0 to 2.4.2 - [Release notes](https://github.com/quarkiverse/quarkus-amazon-services/releases) - [Commits](quarkiverse/quarkus-amazon-services@2.4.0...2.4.2) Updates `io.quarkiverse.amazonservices:quarkus-amazon-common` from 2.4.0 to 2.4.2 --- updated-dependencies: - dependency-name: io.quarkiverse.amazonservices:quarkus-amazon-services-bom dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkiverse.amazonservices:quarkus-amazon-common dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Necessary to catch up with quarkus-amazon-services See quarkiverse/quarkus-amazon-services#836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to catch up with quarkus-amazon-services, which migrated to
@ConfigMapping. The build just fails otherwise because we'd be mixing@ConfigMappingfrom quarkus-amazon-servivces with old-style configuration.The generated documentation for configuration properties is not great at the moment (it only mentions configuration for named PUs/backends) because Quarkus 3.2 doesn't include quarkusio/quarkus#34514 , but it's simpler that way. Let's wait for a backport in 3.2 or for 3.3 to get correct documentation.