Fix #40 to support rest client #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The classic-resteasy-client is failing with I tried to add The reactive-rest-client is failing with I'm not sure how to fix it. @geoand any hint? |
geoand
reviewed
Nov 28, 2024
Comment on lines
+97
to
+109
| private void registerHandler(RuntimeType type, | ||
| BuildProducer<MessageBodyReaderBuildItem> additionalReaders, | ||
| BuildProducer<MessageBodyWriterBuildItem> additionalWriters) { | ||
| additionalReaders.produce(new MessageBodyReaderBuildItem.Builder( | ||
| ReactiveFurySerializer.class.getName(), Object.class.getName()) | ||
| .setMediaTypeStrings(List.of("application/fury", "application/*+fury")) | ||
| .setRuntimeType(type) | ||
| .setBuiltin(true).build()); | ||
| additionalWriters.produce(new MessageBodyWriterBuildItem.Builder( | ||
| ReactiveFurySerializer.class.getName(), Object.class.getName()) | ||
| .setMediaTypeStrings(List.of("application/fury", "application/*+fury")) | ||
| .setRuntimeType(type) | ||
| .setBuiltin(true).build()); |
There was a problem hiding this comment.
ReactiveFurySerializer is a server part, so it won't work for the client
There was a problem hiding this comment.
Hmm, but it still implements both MessageBodyReader and MessageBodyWriter.
geoand
reviewed
Nov 28, 2024
Comment on lines
87
to
88
| resteasyJaxrsProviderBuildItemBuildProducer | ||
| .produce(new ResteasyJaxrsProviderBuildItem(FurySerializer.class.getName())); |
There was a problem hiding this comment.
I am not sure if this is enough for RESTEasy Classic. You probable also have to use META-INF/services/jakarta.ws.rs.ext.Providers like RESTEasy does in the resteasy-json-binding-provider module for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to disable the native test on
testClientcurrently and will open an issue to investigate it.