Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HTTP proxy settings if they exist #671

Closed
wants to merge 1 commit into from
Closed

Set HTTP proxy settings if they exist #671

wants to merge 1 commit into from

Conversation

gastaldi
Copy link
Member

@gastaldi gastaldi commented Nov 28, 2024

May fix quarkusio/quarkus#44802 (comment)
(Waiting for the OP's confirmation)

@gastaldi gastaldi requested a review from a team as a code owner November 28, 2024 13:48

This comment has been minimized.

@gastaldi gastaldi marked this pull request as draft November 28, 2024 13:53
Copy link
Contributor

@zhfeng zhfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

@turing85
Copy link
Contributor

@gastaldi should this PR be backported to quarkus 3.8 and/or 3.15?

Copy link

github-actions bot commented Nov 28, 2024

🚦Reports for run #1604🚦

Reports will be posted here as they get available.

🥳 JUnit JVM Test passed

Passed Failed Skipped
✅ 181 ❌ 0 ⚠️ 0

You can see the report here.

🥳 JUnit Native Test passed

Passed Failed Skipped
✅ 113 ❌ 0 ⚠️ 0

You can see the report here.

@gastaldi
Copy link
Member Author

3.15 perhaps, 3.8 not sure. But I'm interested in knowing if that really fixes the problem first

@turing85
Copy link
Contributor

turing85 commented Dec 9, 2024

Closed since quarkusio/quarkus#44802 has been closed.

@turing85 turing85 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants