Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Mapping: use SmallRye's @ConfigMapping #81

Closed
turing85 opened this issue Oct 13, 2022 · 2 comments · Fixed by #303
Closed

Configuration Mapping: use SmallRye's @ConfigMapping #81

turing85 opened this issue Oct 13, 2022 · 2 comments · Fixed by #303
Assignees

Comments

@turing85
Copy link
Contributor

The official guide requires the use of SmallRye's @ConfigMapping. We currently do not use this mechanism, but classes. We should rewrite the configuration classes to be in line with the official guide.

@turing85
Copy link
Contributor Author

turing85 commented Oct 28, 2022

FTR: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/quarkus.20extension.3A.20using.20.40ConfigMapping/near/303892746

Using @ConfigMapping has some limitations right now. Most notably:

  • There is not builtin way to create "default" instances of a mapping. The recommended way is to implement the interface (e.g. through an anonymous class) and return an instance of that implementation. There is was an open feature request for this.
  • The only way to exclude a method (e.g. a default-method) from being shown in the documentation is to mark it as @Deprecated.

@turing85
Copy link
Contributor Author

turing85 commented Feb 11, 2023

Since there are some features still missing from @ConfigMapping (e.g. a way to instantiate a default object, or withhold certain parts of the configuration from documentation), I have set the issue on hold for the time being until appropiate features are available.

turing85 added a commit that referenced this issue Oct 17, 2023

Verified

This commit was signed with the committer’s verified signature.
turing85 Marco Bungart
Resolves #81
@turing85 turing85 self-assigned this Oct 17, 2023
turing85 added a commit that referenced this issue Oct 18, 2023

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Resolves #81
turing85 added a commit that referenced this issue Oct 18, 2023

Verified

This commit was signed with the committer’s verified signature.
turing85 Marco Bungart
Resolves #81

(cherry picked from commit 49d6f32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant