Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smallrye-health as optional dependency #25

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

ggrebert
Copy link
Contributor

@ggrebert ggrebert commented Feb 3, 2024

Set the smallrye-health dependency as optional following the quarkus way: https://quarkus.io/guides/writing-extensions#extension-health-check

@ggrebert ggrebert requested a review from a team as a code owner February 3, 2024 12:17
Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again another fantastic improvement! I did not realize the healthcheck could be done this way!

@melloware melloware merged commit 28023a5 into quarkiverse:main Feb 3, 2024
1 check passed
@ggrebert
Copy link
Contributor Author

ggrebert commented Feb 3, 2024

Once again another fantastic improvement! I did not realize the healthcheck could be done this way!

So reactive ! 😄 ❤️

@melloware
Copy link
Contributor

Thanks for all these great improvements. Once you think its ready we can cut a 1.0.0 release.

@ggrebert
Copy link
Contributor Author

ggrebert commented Feb 3, 2024

For the 1.0.0 release I think we should wait for the reactive way of the extension to reduce the deprecations.
But you can release a new 0.x version

@ggrebert ggrebert deleted the auto-health branch February 7, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants