Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook tests for block encodings #1235

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

charlesyuan314
Copy link
Contributor

No description provided.

@anurudhp
Copy link
Contributor

anurudhp commented Aug 1, 2024

Are these notebook tests needed anymore? The CI seems to just run dev_tools/execute-notebooks.py which collects and runs all notebooks.

notebooks:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: ts-graphviz/setup-graphviz@v1
- uses: actions/setup-python@v4
with:
python-version: "3.10"
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r dev_tools/requirements/envs/pytest.env.txt
pip install --no-deps -e .
- run: |
python dev_tools/execute-notebooks.py

@charlesyuan314
Copy link
Contributor Author

This is what I got from @mpharrigan:

there should be a pytest for each notebook marked with that mark so local users can easily check the notebooks alongside their unit tests and isolate failures

@fdmalone
Copy link
Collaborator

fdmalone commented Aug 1, 2024

The notebook tests are skipped for pytest during the CI (tested via execute_notebook) but will run locally (if you forget to -m "not notebook")

@charlesyuan314 charlesyuan314 enabled auto-merge (squash) August 5, 2024 17:34
@charlesyuan314 charlesyuan314 merged commit 18bac8f into quantumlib:main Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants