Add FSimViaModel Gate into device.proto #6548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6548 +/- ##
========================================
Coverage 97.78% 97.78%
========================================
Files 1107 1124 +17
Lines 95188 95468 +280
========================================
+ Hits 93079 93355 +276
- Misses 2109 2113 +4 ☔ View full report in Codecov by Sentry. |
BichengYing
changed the title
BichengYing
requested review from
wcourtney,
vtomole,
cduck,
verult and
a team
as code owners
verult
approved these changes
Apr 4, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
* Add FSimViaModel Gate * Update the name * Add serialization on grid device * Fix the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server side is not read yet. Here just add the proto and serialization and deserialization support in
cirq-google/device. Again, the FSimViaModel is different from existing FSim gate translation. It is controlled via the tag.CC: @eliottrosenberg @senecameeks